[Yanel-dev] [PATCH] Pagination of search results

[Mehmet Birgi]

Yes, you are right in all points. The fact is that I used a customer
project for testing, so I couldn't include these files in this list,
but the way you suggest is far better, I just didn't think of it. I
can still do it, if you like, or haven't done it already.



On Thu, Jul 15, 2010 at 9:29 AM, Michael Wechner
<michael.wechner at wyona.com> wrote:
> Mehmet Birgi wrote:
>>
>> Hi All
>>
>> I am attaching to this posting a patch for
>>
>> /yanel-search-resource-type/src/java/org/wyona/yanel/impl/resources/search/SearchResource.java.
>> The XML delivered by the patched resource will have additional content
>> that can be used by XSLT for paginating search results. The changes
>> should be completely backward compatible as the already existing
>> content has not changed.
>>
>
> thanks very much for this patch. I am currently reviewing it. Just a few
> notes:
>
> - it would be nice if you could create a patch with the full path in the
> future, because it's easier to apply, it makes
> sure to be unique and allows to contains several changed files
>
> - in order to simplify review it would be great to also have the files to
> actually test it and containing documentation, e.g.
>     - src/contributions/resources/search/resource.xml
>     -
> src/realms/from-scratch-realm-template/res-configs/en/search.html.yanel-rc
>     - src/contributions/resources/search/htdocs/results2xhtml.xsl
>
> - and a refactored test:
>    - http://127.0.0.1:8080/yanel/test/use-cases/#search-with-yarep
>    -
> http://127.0.0.1:8080/yanel/test/use-cases/yanel/search.html?q=Hello&provider=yanel
>
> Having said this any patch/improvement is of course very welcome :-)
>
> Thanks
>
> Michi
>>
>> Cheers,
>>
>> Memo
>>
>>
>>
>>
>
> --
> Yanel-development mailing list Yanel-development at wyona.com
> http://lists.wyona.org/cgi-bin/mailman/listinfo/yanel-development
>



-- 
Mehmet Birgi
www.wyona.com