[Yanel-dev] [PATCH] Pagination of search results

Michael Wechner michael.wechner at wyona.com
Thu Jul 15 09:29:08 CEST 2010


Mehmet Birgi wrote:
> Hi All
>
> I am attaching to this posting a patch for
> /yanel-search-resource-type/src/java/org/wyona/yanel/impl/resources/search/SearchResource.java.
> The XML delivered by the patched resource will have additional content
> that can be used by XSLT for paginating search results. The changes
> should be completely backward compatible as the already existing
> content has not changed.
>   

thanks very much for this patch. I am currently reviewing it. Just a few 
notes:

- it would be nice if you could create a patch with the full path in the 
future, because it's easier to apply, it makes
sure to be unique and allows to contains several changed files

- in order to simplify review it would be great to also have the files 
to actually test it and containing documentation, e.g.
      - src/contributions/resources/search/resource.xml
      - 
src/realms/from-scratch-realm-template/res-configs/en/search.html.yanel-rc
      - src/contributions/resources/search/htdocs/results2xhtml.xsl

- and a refactored test:
     - http://127.0.0.1:8080/yanel/test/use-cases/#search-with-yarep
     - 
http://127.0.0.1:8080/yanel/test/use-cases/yanel/search.html?q=Hello&provider=yanel

Having said this any patch/improvement is of course very welcome :-)

Thanks

Michi
> Cheers,
>
> Memo
>
>
>
>   



More information about the Yanel-development mailing list