[Yanel-dev] Toolbar

[Josias Thöny]

Michael Wechner wrote:
> Hi
> 
> The Toolbar menus are now configurable per Realm, e.g. take a look at 
> the Welcome or Yanel Website realm configuration:
> 
> src/realms/welcome-admin/yanel/config/yanel-realm-config.xml
> 
> src/realms/yanel-website/config/yanel-realm-config.xml
> 
> whereas this lead me to the first questio if one shouldn't use a 
> different namespace for this and also
> more the method Realm.getMenuClass() into some other class, because this 
> seems to me a "webapp thing" and not
> really part of the core?

I see two alternative solutions:
- add properties to the realm: realm.getProperty("menu-class")
   (it might be a bit more generic)
- attach the menu class to the realm: realm.getMenu(....)

Not sure if any of those two solutions is better than the one you 
implemented...

> 
> WDYT?
> 
> My second question is about the API:
> 
> src/core/java/org/wyona/yanel/servlet/menu/Menu.java
> 
> which I did very quickly and I am sure some of you have much better 
> ideas how to do this better.
> 
> Any suggestions are very welcome :-)

I don't have any suggestions right now...

> 
> My third question is about how we shall add java libraries of a realm, 
> for instance the class
> 
> src/core/java/org/wyona/yanel/servlet/menu/impl/YanelWebsiteMenu.java
> 
> should rather go into the Yanel Website Realm, which I guess means that 
> a realm can also have a build.xml file just as
> a resource has.

Yeah, the build system would have to be modified to build the java code 
of each realm. I don't know whether the central yanel build.xml should 
build the realms, or if each realm should have its own build.xml.

> 
> WDYT?
> 
> My fourth point is not a question but rather a comment that I will also 
> make the menus configurable per resource configuration

If some menu entries come from the realm, and some from the resource, 
would it make sense to have menu sections named "Realm" and "Resource", 
instead of "File"/"Edit"/whatever?

Josias


> 
> Thanks
> 
> Michi
>