[Yulup] Exit button not working when editing locally

[Jonathan Addison]

Hi Andreas,

Andreas Wuest wrote:
> Hi Jonathan
>
> On 19.1.2007 22:03 Uhr, Jonathan Addison wrote:
>
>> Hi Andreas,
>>
>> Andreas Wuest wrote:
>>> Hi Jonathan
>>>
>>> On 16.1.2007 19:52 Uhr, Jonathan Addison wrote:
>>>
>>> [ snip ]
>>>
>>>> Yes I'm using the source version.  I tested again with 2 tabs open 
>>>> instead of just 1. Exit after checking out returns me to the 
>>>> original page within the same tab, whereas exit after editing 
>>>> locally closes the tab.
>>>
>>> That's the expected behaviour.
>>
>> Ok, wouldn't the user expect to be taken back to the original page in 
>> both cases.  I don't see why checking out (or not checking out) a 
>> document would make any difference in relation to the tabs.
>
> Well, when editing locally, you might start from looking at a web 
> page. You then edit it locally, and might save it to the file system. 
> Returning the user back to the web page doesn't make much sense, 
> because the user did not really edit that page.
>
> I could, instead, try to reroute the user to his local copy of the 
> edited page. But if he did not save his changes, then we are stuck as 
> well.
>
> I have to think about what would be sensible behaviour in those cases.

Ok I see what you're saying now, you're trying to show them the results 
of the editing.  I guess I'm used to when Yulup opened in a new tab, and 
then the Exit button would always close that new tab.

>
>>>> By the way, the New and Open buttons work fine in both situations.
>>>
>>> That's good, and, since it seems like I finally figured out the 
>>> cause of this bug, entirely reasonable.
>>>
>>> You don't happen to have, by any chance, "Always show the tab bar" 
>>> in the Firefox Tab Preferences unchecked?
>>
>> No, but I do have 'Hide the tab bar when only one web site is open' 
>> checked, which would lead to the same behaviour ;).
>
> Heh, I wonder why they would call that pref differently on different 
> platforms. *shakes head*

I'm still using FF 1.5, so they've probably changed the wording.

>
>>
>>> I merely stumbled on this by looking at a fresh Firefox install, 
>>> which has this pref not set by default. If I uncheck it, I can also 
>>> reproduce the bug on my machine.
>>>
>>> Now, knowing the cause, it should not take me too long to fix it. :)
>>
>> Ok, great, thanks for looking at it :).
>
> No problem!
>


-- 
Jonathan Addison                                 jon<at>wyona.com
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org