[Yulup] Order of icons changes with repeated editing

[Andreas Wuest]

Hi Jonathan

On 5.12.2006 23:53 Uhr, Jonathan Addison wrote:

> Hi Andreas,
> 
> Andreas Wuest wrote:
>> Hi Jonathan
>>
>> On 5.12.2006 15:57 Uhr, Andreas Wuest wrote:
>>
>>> Hi Jonathan
>>>
>>> On 5.12.2006 14:57 Uhr, Jonathan Addison wrote:
>>>
>>>> Hi Andreas,
>>>>
>>>> I just noticed this today on my XP machine.  If I edit and close a 
>>>> document several times in a row the bold, italic, and underline 
>>>> icons get moved all the way to the right.  I have attached a 
>>>> screenshot, and  I am using the dev version of Yulup.
>>>
>>> I guess this is because of the toolbarbutton append code, which 
>>> inserts them depending on which thread finishes first.
>>>
>>> I'll report back as soon as I've fixed it.
>>
>> I have fixed this in revision 20598.
>>
>> The problem was that we added the toolbarbuttons in the 
>> installWidget() method, which gets called for every widget after an 
>> asynchronous widget image load.
>>
>> Sine the load is asynchronous, one of the loading threads could get 
>> ahead of a previously started thread under certain conditions, thereby 
>> destroying the order in which the widgets were specified.
>>
>> We now add the toolbarbuttons during the call to addWidgets(), where 
>> we loop over all registered widgets, and therefore preserve the 
>> specified order.
>>
>> For more information on the Yulup editor startup process, see 
>> http://svn.wyona.com/repos/public/yulup/website/deliverables/design/figures/editor_startup_process-redesign.png. 
>>
> 
> Thanks very much ;), will test shortly and report if there are any issues.

Cool, thanks a lot!! :)

-- 
Kind regards,
Andi