<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Hi<br>
<br>
Thanks to Marc the annotations are now also added to the access log:<br>
<br>
Sending
src/webapp/src/java/org/wyona/yanel/servlet/AccessLog.java<br>
Sending
src/webapp/src/java/org/wyona/yanel/servlet/YanelServlet.java<br>
Transmitting file data ..<br>
Committed revision 56923.<br>
<br>
whereas the results of the review are:<br>
<br>
<ul>
<li>Does it build? YES (but it didn't originally because it broke
backwards compatibility)</li>
<li>Is the formatting correct? Should be fixed now (used tabs
instead of spaces)<br>
</li>
<li>Is there an automatic test? Make sure that there are automatic
tests, which are covering the changes which the patch will
imply. NO<br>
</li>
<li>Is it backwards compatible? YES (but it was broken, see
src/contributions/resources/contact-form/src/java/org/wyona/yanel/impl/resources/contactform/ContactResource.java)<br>
</li>
<li>Does it scale/perform? (Can the implementation be changed?)
YES and NO, because the logging has become slower, but the
analysis will become faster and it is a workaround for the
revision problem<br>
</li>
<li>Can it be enhanced? Kind of ...<br>
</li>
<li>Can it be customized? The annotation implementation can be
customized ....<br>
</li>
<li>Does it work within a cluster? YES<br>
</li>
<li>Is it secure? YES and NO, depends if the annotations contain
"secret" information<br>
</li>
<li>Can it be used offline? YES<br>
</li>
<li>Can the patch be reverted easily? YES<br>
</li>
<li>Does it work for all browsers? Only tested Firefox yet</li>
</ul>
<br>
Btw, I have also fixed that if a URL contains a query string that
this is also written into the access log file,<br>
because for example in the case of introspection the "same" URL is
called twice be the browser, e.g.<br>
<br>
<a class="moz-txt-link-freetext" href="http://127.0.0.1:8080/yanel/yanel-website/en/about.htm?yanel.resource.usecase=introspection">http://127.0.0.1:8080/yanel/yanel-website/en/about.htm?yanel.resource.usecase=introspection</a><br>
<br>
Cheers<br>
<br>
Michael<br>
<br>
<br>
On 2/22/11 9:35 AM, Michael Wechner wrote:
<blockquote cite="mid:4D637541.6080202@wyona.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi<br>
<br>
Thanks to Marc Schaaf we now have an "Annotatable" interface which
allows to annotate resources<br>
and also use this information for third party applications, e.g.
Boost in order to generate tag clouds re what users are interested
in. Marc has also created a simple annotation editor which is
currently used by the yanel website realm. <br>
<br>
I guess Marc will send some more notes re further steps (e.g. re
ontologies: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://en.wikipedia.org/wiki/Ontology_%28information_science%29">http://en.wikipedia.org/wiki/Ontology_%28information_science%29</a>)<br>
<br>
The basic code pieces are:<br>
<br>
U conf/resource-types.xml<br>
A
src/realms/yanel-website/res-configs-repo/data/usecases/pageMetadataManager.html.yanel-rc<br>
U
src/realms/yanel-website/src/java/org/wyona/yanel/website/menu/impl/YanelWebsiteMenu.java<br>
U src/realms/yanel-website/data-repo/data/xslt/global.xsl<br>
A
src/core/java/org/wyona/yanel/core/api/attributes/AnnotatableV1.java<br>
U
src/resources/xml/src/java/org/wyona/yanel/impl/resources/XMLResource.java<br>
A src/resources/pageMetaDataManager<br>
A
src/resources/pageMetaDataManager/src/java/com/wyona/yanel/metadata/manager/PageMetaDataManager.java<br>
<br>
Re code review:<br>
<br>
<ul>
<li>Does it build? YES<br>
</li>
<li>Is the formatting correct? Should be fixed now (used tabs
instead of spaces)<br>
</li>
<li>Is there an automatic test? Make sure that there are
automatic tests, which are covering the changes which the
patch will imply. NO<br>
</li>
<li>Is it backwards compatible? YES, because annotations are
implemented as a versioned interface<br>
</li>
<li>Does it scale/perform? (Can the implementation be changed?)
YES, because of doing it as an interface<br>
</li>
<li>Can it be enhanced? YES, because of versioned interface<br>
</li>
<li>Can it be customized? The implementation can be customized<br>
</li>
<li>Does it work within a cluster? NOT really, because the
properties are not locked yet, but we will fix that shortly.
But also depends on the repository implementation.<br>
</li>
<li>Is it secure? YES, if the policies for the editor are set
correctly, but NO otherwise<br>
</li>
<li>Can it be used offline? YES<br>
</li>
<li>Can the patch be reverted easily? NO, because various
resource types (e.g. XMLResource) will start implementing this
interface<br>
</li>
<li>Does it work for all browsers? Only tested Firefox yet</li>
</ul>
Cheers<br>
<br>
Michael<br>
<br>
<br>
</blockquote>
<br>
</body>
</html>