[Yanel-dev] Patch for YarepUser.java

Michael Wechner michael.wechner at wyona.com
Thu May 19 10:42:42 EDT 2016


agreed :-)

Am 19.05.16 um 15:57 schrieb basZero:
> no I didn't close anything. I guess this was done automatically
> (because github knows that you fetched my pull request and merged it).
>
> please note that you used "Balz" as your local branch name... so when
> you fetch my next pull request, I'd use a different name, maybe
> "balzpatch2" or something like that.
> I will use patch1 to patchX for all upcoming patches to wyona repos.
>
> Cheers
> Balz
>
> On Thu, May 19, 2016 at 3:35 PM, Michael Wechner
> <michael.wechner at wyona.com <mailto:michael.wechner at wyona.com>> wrote:
>
>     that sounds great  :-) thanks very much!
>
>     Btw, the process via pull request works very fine, whereas I have
>     pulled it as follows
>
>     git fetch origin pull/5/head:Balz
>
>     I am not sure how pull requests get closed. Did you just close it
>
>     https://github.com/wyona/security/pulls
>
>     ?
>
>     Thanks
>
>     Michael
>
>     Am 19.05.16 um 15:30 schrieb basZero:
>>     Thanks Michael, 
>>     no rush regarding integration into Yanel. I just wanted to
>>     contribute und make sure they get in as quickly as possible.
>>
>>     I'll send more patches, I'm currently upgrading to the very
>>     latest Yanel version.
>>
>>     Cheers
>>
>>
>>     On Thu, May 19, 2016 at 3:23 PM, Michael Wechner
>>     <michael.wechner at wyona.com <mailto:michael.wechner at wyona.com>> wrote:
>>
>>         Hi Balz
>>
>>         I have reviewed, slightly changed and merged/pushed it
>>
>>         https://github.com/wyona/security/commits/master/src/impl/java/org/wyona/security/impl/yarep/YarepUser.java
>>
>>         https://github.com/wyona/security/commit/173cf3f249c11d61f48f59f66e58b8d737549272#diff-5a495b4b80366327c00938fa50596480
>>
>>         I will now integrate this new version into Yanel. Will write
>>         later again...
>>
>>         Thanks
>>
>>         Michael
>>
>>
>>         Am 19.05.16 um 11:19 schrieb basZero:
>>>         Hi Michael,
>>>
>>>         I create a super simple patch for YarepUser.java:
>>>         https://github.com/wyona/security/pull/5
>>>
>>>         I hope you find time to apply it soon.
>>>
>>>         Cheers
>>>
>>>
>>
>>
>>         --
>>         Yanel-development mailing list Yanel-development at wyona.com
>>         <mailto:Yanel-development at wyona.com>
>>         http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>>
>>
>>
>>
>
>
>     --
>     Yanel-development mailing list Yanel-development at wyona.com
>     <mailto:Yanel-development at wyona.com>
>     http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mx2.wyona.com/pipermail/yanel-development/attachments/20160519/39a097f0/attachment.html>


More information about the Yanel-development mailing list