[Yanel-dev] Pending Pull Request

Wed Jun 8 15:42:23 EDT 2016

Hi Michael,
no this configuration approach you have chosen is ok for me, I just didn't
understand you initially, now I see the point.

Thanks for that. Cheers, Balz

On Wed, Jun 8, 2016 at 9:38 PM, Michael Wechner <michael.wechner at wyona.com>
wrote:

> Hi Balz
>
> See my comments below
>
> Am 08.06.16 um 15:11 schrieb basZero:
>
> Hi Michael,
>
> I don't really understand your statement "then the browser does not check
> anymore whether the location has changed", can you give me more info on
> that? URL?
>
>
> when you access for example on one day
>
> http://foo.bar
>
> and on the next day you access it again
>
> http://foo.bar
>
> When you set on this URL a permanent redirect, then for example Firefox
> does not check again the location, but uses the cached redirect of the day
> before.
>
>
> My pull request was to make redirects better for search engines (SEO). So
> what is done for logged in users is anyway irrelevant for SEO, as all
> search engines are anonymous visitors.
>
>
> yes, but for dynamic redirects the difference between 301 and 307 is not
> irrelavent, but crucial.
>
> I do understand the importance of your requirement, but the requirement of
> temporary/dynamic redirects is also important, and because so far we used
> 307 as default, we cannot just change to 301 as default, because the
> expected behaviour would not work anymore.
>
> As said, the alternative would be introduce a new version of the redirect
> resource and make 301 the default. Then everyone will be happy :-) I can do
> this if you think configuring 301 inside the resource configuration is too
> complicated.
>
> Thanks
>
> Michael
>
>
> Thanks
>
> On Wed, Jun 8, 2016 at 2:59 PM, Michael Wechner <michael.wechner at wyona.com
> > wrote:
>
>> Hi Balz
>>
>> I understand your argument about the "link juice", but there are
>> situations like for example the following:
>>
>>
>> Not-signed in user:
>>
>>   http://foo.bar  -> <http://foo.bar/en/index.html>
>> http://foo.bar/en/index.html
>>
>> Signed in user:
>>
>>   http://foo.bar -> <http://foo.bar/en/projects.html>
>> http://foo.bar/en/projects.html
>>
>> Now the second case might change at some point or is even dynamic, e.g.
>>
>>   http://foo.bar -> <http://foo.bar/en/overview.html>
>> http://foo.bar/en/overview.html
>>
>> When one is using a 301, then the browser does not check anymore whether
>> the location has changed and such a case will fail. Using 307 it will work.
>>
>> But let me see what I can do :-)
>>
>> Thanks
>>
>> Michael
>>
>> Am 08.06.16 um 13:39 schrieb basZero:
>>
>> Yes,
>> but to be honest, I would set 301 as default but I understand that you
>> want to keep Yanel as it was (backwards compatibility).
>>
>> However I think that having 301 by default in place would help all web
>> applications. Nobody want to avoid the "link juice" benefit.
>>
>> Cheers, Balz
>>
>> On Wed, Jun 8, 2016 at 1:31 PM, Michael Wechner <
>> <michael.wechner at wyona.com>michael.wechner at wyona.com> wrote:
>>
>>> Hi Balz
>>>
>>> You are right. I will do better with the next pull request.
>>>
>>> But what about the functionality itself, is it good for you as I have
>>> done it?
>>>
>>> Thanks
>>>
>>> Michael
>>>
>>> Am 08.06.16 um 11:00 schrieb basZero:
>>>
>>> Hi Michael,
>>>
>>> why didn't you take my pull request, modified it and then merged it with
>>> the master release?
>>> From a contribution point of view it should be clear where the
>>> contributions came from and from which pull request.
>>> Now that history is not visible in the yanel master branch.
>>>
>>> Cheers, Balz
>>>
>>> On Tue, Jun 7, 2016 at 11:16 PM, Michael Wechner <
>>> <michael.wechner at wyona.com>michael.wechner at wyona.com> wrote:
>>>
>>>> Hi Balz
>>>>
>>>> I am currently reviewing
>>>>
>>>> https://github.com/wyona/yanel/pull/80
>>>>
>>>> Can you close
>>>>
>>>> https://github.com/wyona/yanel/pull/75
>>>>
>>>> ?
>>>>
>>>> Thanks
>>>>
>>>> Michael
>>>>
>>>> Am 07.06.16 um 22:57 schrieb Michael Wechner:
>>>>
>>>> Hi Balz
>>>>
>>>> I have implemented "this", whereas I have made it configurable for the
>>>> redirect resource with version "1.0.2", e.g.
>>>>
>>>> <yanel:resource-config xmlns:yanel=
>>>> <http://www.wyona.org/yanel/rti/1.0>
>>>> "http://www.wyona.org/yanel/rti/1.0"
>>>> <http://www.wyona.org/yanel/rti/1.0>>
>>>>   <yanel:rti name="redirect" namespace=
>>>> <http://www.wyona.org/yanel/resource/1.0.2>
>>>> "http://www.wyona.org/yanel/resource/1.0.2"
>>>> <http://www.wyona.org/yanel/resource/1.0.2>/>
>>>>
>>>>   <yanel:property name="href" value="en/index.html"/>
>>>>   <!-- INFO: We use 307 instead 301, such that the redirect is always
>>>> checked, in case the redirect location should change in the future -->
>>>>   <yanel:property name="status-code" value="307"/>
>>>>
>>>>
>>>> which means you can set it now to 301 or whatever.
>>>>
>>>> If you don't set it, then the default is still 307 for backwards
>>>> compatibility reasons, whereas I double checked that to be sure that this
>>>> makes sense.
>>>>
>>>> If you think the configurable version is not enough or that the default
>>>> should be 301, then please let me know, because we could discuss to
>>>> introduce a new redirect version, e.g. "redirect, 2.0.0" which uses 301.
>>>>
>>>> HTH
>>>>
>>>> Michael
>>>>
>>>> Am 03.06.16 um 12:58 schrieb basZero:
>>>>
>>>> Hi,
>>>>
>>>> the easiest of the four pull requests I sent some time ago is this one:
>>>> <https://github.com/wyona/yanel/pull/75>
>>>> https://github.com/wyona/yanel/pull/75
>>>>
>>>> It would be really great if these could be applied asap before they
>>>> become incompatible again (like those I sent years ago).
>>>>
>>>> Cheers, Balz
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Yanel-development mailing list <Yanel-development at wyona.com>
>>>> Yanel-development at wyona.com
>>>> http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Yanel-development mailing list <Yanel-development at wyona.com>
>>> Yanel-development at wyona.com
>>> http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>>>
>>
>>
>>
>>
>>
>> --
>> Yanel-development mailing list Yanel-development at wyona.com
>> http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>>
>
>
>
>
>
> --
> Yanel-development mailing list Yanel-development at wyona.com
> http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mx2.wyona.com/pipermail/yanel-development/attachments/20160608/7d49465a/attachment-0001.html>