[Yanel-dev] Pending Pull Request

[basZero]

Hi Michael,

why didn't you take my pull request, modified it and then merged it with
the master release?
>From a contribution point of view it should be clear where the
contributions came from and from which pull request.
Now that history is not visible in the yanel master branch.

Cheers, Balz

On Tue, Jun 7, 2016 at 11:16 PM, Michael Wechner <michael.wechner at wyona.com>
wrote:

> Hi Balz
>
> I am currently reviewing
>
> https://github.com/wyona/yanel/pull/80
>
> Can you close
>
> https://github.com/wyona/yanel/pull/75
>
> ?
>
> Thanks
>
> Michael
>
> Am 07.06.16 um 22:57 schrieb Michael Wechner:
>
> Hi Balz
>
> I have implemented "this", whereas I have made it configurable for the
> redirect resource with version "1.0.2", e.g.
>
> <yanel:resource-config xmlns:yanel="http://www.wyona.org/yanel/rti/1.0"
> <http://www.wyona.org/yanel/rti/1.0>>
>   <yanel:rti name="redirect" namespace=
> <http://www.wyona.org/yanel/resource/1.0.2>
> "http://www.wyona.org/yanel/resource/1.0.2"
> <http://www.wyona.org/yanel/resource/1.0.2>/>
>
>   <yanel:property name="href" value="en/index.html"/>
>   <!-- INFO: We use 307 instead 301, such that the redirect is always
> checked, in case the redirect location should change in the future -->
>   <yanel:property name="status-code" value="307"/>
>
>
> which means you can set it now to 301 or whatever.
>
> If you don't set it, then the default is still 307 for backwards
> compatibility reasons, whereas I double checked that to be sure that this
> makes sense.
>
> If you think the configurable version is not enough or that the default
> should be 301, then please let me know, because we could discuss to
> introduce a new redirect version, e.g. "redirect, 2.0.0" which uses 301.
>
> HTH
>
> Michael
>
> Am 03.06.16 um 12:58 schrieb basZero:
>
> Hi,
>
> the easiest of the four pull requests I sent some time ago is this one:
> https://github.com/wyona/yanel/pull/75
>
> It would be really great if these could be applied asap before they become
> incompatible again (like those I sent years ago).
>
> Cheers, Balz
>
>
>
>
>
> --
> Yanel-development mailing list Yanel-development at wyona.com
> http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mx2.wyona.com/pipermail/yanel-development/attachments/20160608/3d3ef11e/attachment.html>