[Yanel-dev] package private method in YarepUser

[Michael Wechner]

Am 28.09.11 14:55, schrieb basZero:
> Yes, that's what I did yesterday... :-)

good :-)
>
> it's just a bit dangerous, because somebody still might call the 
> remove() on the userobject (maybe yanel internal code) and use the 
> "wrong" remove method.

I am not sure I understand. Can you explain a bit?
>
> But I hope it works like this...

let me know otherwise

Thanks

Michael
> Cheers
> Balz
>
> On Wed, Sep 28, 2011 at 2:52 PM, Michael Wechner 
> <michael.wechner at wyona.com <mailto:michael.wechner at wyona.com>> wrote:
>
>     Am 28.09.11 14:41, schrieb basZero:
>>     Maybe you need some other cleanup tasks when somebody calls the
>>     removeAlias() method, that was my main purpose.
>>
>>     Also, as of the comments in the YarepUser, the future version of
>>     removeAlias() will check at the end, whether there are no aliases
>>     at all after removal and if so, it would delete the user.
>>     MAYBE, some realms do not want that behaviour so that would be
>>     another reason in future why to overwrite the method.
>
>     What about overwriting
>
>     src/impl/java/org/wyona/security/impl/yarep/YarepUserManager.java#createAlias(...)
>     src/impl/java/org/wyona/security/impl/yarep/YarepUserManager.java#removeAlias(...)
>
>     which are already public methods and implement the actual interface?
>
>     HTH
>
>     Michael
>
>>
>>     Cheers
>>     Balz
>>
>>     *Balz Schreier*
>>     Zwischengas AG
>>     CTO / Fotograf
>>
>>     Kürzlich publizierter Highlight: Arosa ClassicCar 2011
>>     <http://www.zwischengas.com/de/HR/rennberichte/Arosa-ClassicCar-2011-Sonne-Freude-Geschwindigkeit.html>
>>
>>     On Tue, Sep 27, 2011 at 10:09 PM, Michael Wechner
>>     <michael.wechner at wyona.com <mailto:michael.wechner at wyona.com>> wrote:
>>
>>         Hi Balz
>>
>>         Am 27.09.11 17:12, schrieb basZero:
>>>         Hi Michael,
>>>
>>>         often you extend the YarepUser class by using inheritance
>>>         and of course the realm specific user class is in another
>>>         package.
>>>
>>>         because the following method has visibility "package
>>>         private", it is impossible to overwrite it, nor it is
>>>         possible to call it.
>>>
>>>         void removeAlias(String id) throws AccessManagementException;
>>>
>>>         Can you make this method protected please?
>>
>>         can you explain a bit why you want to overwrite this method?
>>         Just trying to understand
>>         and maybe we can find an alternative (maybe better) approach.
>>
>>         What is the reason that you don't need
>>         YarepUser#addAlias(String) as protected?
>>
>>         Thanks
>>
>>         Michael
>>
>>
>>>
>>>         Thanks.
>>>         Cheers
>>>         Balz
>>>
>>>
>>>         *Balz Schreier*
>>>         Zwischengas AG
>>>         CTO / Fotograf
>>>
>>>         Kürzlich publizierter Highlight: Arosa ClassicCar 2011
>>>         <http://www.zwischengas.com/de/HR/rennberichte/Arosa-ClassicCar-2011-Sonne-Freude-Geschwindigkeit.html>
>>>
>>>
>>>
>>
>>
>>         --
>>         Yanel-development mailing list Yanel-development at wyona.com
>>         <mailto:Yanel-development at wyona.com>
>>         http://lists.wyona.org/cgi-bin/mailman/listinfo/yanel-development
>>
>>
>>
>>
>
>
>     --
>     Yanel-development mailing list Yanel-development at wyona.com
>     <mailto:Yanel-development at wyona.com>
>     http://lists.wyona.org/cgi-bin/mailman/listinfo/yanel-development
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wyona.org/pipermail/yanel-development/attachments/20110928/040bd013/attachment.html>