[Yanel-dev] Allow iframe by TinyMCE

Michael Wechner michael.wechner at wyona.com
Thu Oct 27 00:26:09 CEST 2011


Hi Balz

Am 26.10.11 16:40, schrieb basZero:
> Hi Michael,
> thanks for the info.
>
> As Yanel is now github based, I'd recommend the following for such 
> code change suggestions in future:
>
> - You create an issue with the content of your mail
> - You send an email to this distribution list with just the link to 
> the github issue

https://github.com/wyona/yanel/issues/5

> - people can reply via mail or via commenting the issue

Looking forward to replies ;-)
>
> and now the important part:
> - if you commit your change to Yanel, you add this into the commit 
> message: "closes #132" (where 132 is an example for the issue ID).
> - if you push your local branch to github, github automatically closes 
> the issue #132 and makes a hyperlink to the commit.
> - this way people can very easily read and understand what has been 
> changed and they can also jump to the code very easily.

thanks very much for pointing this out. Will try to do it.

Thanks

Michael
>
> Cheers
> Balz
>
> On Wed, Oct 26, 2011 at 4:27 PM, Michael Wechner 
> <michael.wechner at wyona.com <mailto:michael.wechner at wyona.com>> wrote:
>
>     Hi
>
>     Somebody recently asked me how to make TinyMCE not drop iframe
>     code when using the HTML mode.
>     I think the following patch should work:
>
>     git diff src/resources/tinymce/htdocs/js/tinymceinit_3_3_5_1.js
>     diff --git
>     a/src/resources/tinymce/htdocs/js/tinymceinit_3_3_5_1.js
>     b/src/resources/tinymce/htdocs/js/tinymceinit_3_3_5_1.js
>     index 3784be5..15350f9 100644
>     --- a/src/resources/tinymce/htdocs/js/tinymceinit_3_3_5_1.js
>     +++ b/src/resources/tinymce/htdocs/js/tinymceinit_3_3_5_1.js
>     @@ -7,6 +7,7 @@ tinyMCE.init({
>            theme_advanced_toolbar_align : "left",
>            theme_advanced_statusbar_location : "bottom",
>            theme_advanced_resizing : true,
>     +        extended_valid_elements :
>     "iframe[src|width|height|name|align]",
>            entity_encoding : "numeric",
>            file_browser_callback : 'yanelLookupResource',
>      });
>
>     I will test it some more and if no problems or objections, then I
>     would commit/push it.
>
>     Thanks
>
>     Michael
>     -- 
>     Yanel-development mailing list Yanel-development at wyona.com
>     <mailto:Yanel-development at wyona.com>
>     http://lists.wyona.org/cgi-bin/mailman/listinfo/yanel-development
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wyona.org/pipermail/yanel-development/attachments/20111027/e455d7e7/attachment.html>


More information about the Yanel-development mailing list