[Yanel-dev] Access Log Format

[Michael Wechner]

Hi Cedric

On 2/9/11 4:47 PM, Cedric Staub wrote:
> Hello there!
>
> Remember when we changed the format of the access logfile Yanel
> generates? Back then, I created a function which generates the string
> for the access log, so that other functions can call it instead of
> having to build the string themselves.
>
> Well, as it turns out, I forgot to change it in one place! That means
> Yanel now generates mixed old/new formatted access logs depending on the
> situation, which is not very nice. You won't notice it until you try to
> automatically parse the logfile, at which point you will see that some
> access log lines differ from the others.
>
> I attached a patch to fix the problem! It changes only a single line.
>
> About the patch:
> - Does it build?  Yes
> - Is the formatting correct?  Yes
> - Is it backwards compatible? No, but that's the point.
> - Does it scale/perform? N/A

It seems to me it's not worse than the existing version :-)
> - Can it be enhanced? Yes
> - Can it be customized? No
> - Does it work within a cluster? Yes
> - Is it secure? Well, I guess so.

It seems to me it's not worse than the existing solution :-)

> - Can it be used offline? Yes
> - Can the patch be reverted easily? Yes
> - Does an automatic test exist? No

something we should discuss with Marc

> - Does it work for all browsers? N/A

Thanks very much for answering the review questions.

Please go ahead and commit it and thanks again for this patch

Michael
> Cheers
> Cedric