[Yanel-dev] Re: Patch für MailUtil

[Michael Wechner]

Dear Balz

I have reviewed your patch and two notes:

1) Please make sure to use the "fullpath" when generating patches, e.g.

Index: src/core/java/org/wyona/yanel/core/util/MailUtil.java

instead

Index: MailUtil.java

because it will make it easier to apply

2)  I have implemented the fromName feature by enhancing an existing 
method and in order
to stay backwards compatible  introduced the "same" method as 
deprecated. The authentication
I have implemented via the session object in order to make use of the 
global configuration.
I think this way there is less replicated code.

I have introduced additionally a "simple" method

send(String fromAddress, String fromName, String replyTo, String to, 
String subject, String content)

Btw, I am not sure if you have created a Bugzilla entry for your patch, 
but if so you might want
to send the link to me or close it yourself after testing the new 
enhancements.

Sending        src/core/java/org/wyona/yanel/core/util/MailUtil.java
Transmitting file data .
Committed revision 53151.

Cheers

Michael


Balz Schreier wrote:
> Hoi Michi,
>
> habe eine neue Methode implementiert und getestet mit dem produktiven 
> Zwischengas Mail Server.
>
> Ein neuer Paramter ist "fromName", der ist noch schön, damit der 
> Empfänger nicht die fromEmailAddress sieht sondern einen "Namen" des 
> Empfängers,
> z.b. "Zwischengas Newsletter" anstatt "do-not-reply at zwischengas.com 
> <mailto:do-not-reply at zwischengas.com>".
>
> Das DIFF ist attached.
>
> Gruess
> Balz