[Yanel-dev] Storing reviewer comments with workflow transitions

[Michael Wechner]

On 11/4/10 12:28 PM, Rob Adamson wrote:
>>> I think I understand.
>>>
>>> The problem is that there isn't any way to set a revision property
>>> through either WorkflowableV1 or VersionableV2.
>> IIUC you want to set the "reject message" as property (as we discussed ;-),
>> right?
> Yes, I thought that was clear from the previous messages in this thread.

my bad, I was confusing myself ;-)


>>> So as a work-around, I will take the path of the node as an additional
>>> request parameter.
>> or you could try to do this via the Modifiable interface, e.g.
>>
>> http://www.yanel.org/javadoc/org/wyona/yanel/core/api/attributes/ModifiableV2.html#write(InputStream)
>>
>> whereas you could generate an InputStream with for example
>>
>> new java.io.StringBufferInputStream(sb.toString())
>>
>> and the "write(InputStream)" implementation would read this and set the
>> property on the node.
> I think the problem with this is *knowing* that the implementation
> will perform that operation.

agreed


>   It did occur to me that we could create a
> new interface for this purpose? Or maybe a new version of Versionable,
> with a method to set the property of a revision.

yes, please feel free to make a suggestion in order to discuss


> Anyway, for now I am explicitly including code to get the repository
> path from the resource path.

maybe you can add a TODO with a reference to this thread in order to 
pick this up again at some later
stage.


Cheers

Michael

> Thanks,
> Rob