[Yanel-dev] SendMail utility class

[Guillaume Déflache]

Michael Wechner wrote:
> Hi

Hi!


> I have noticed that the class
> 
> src/java/org/wyona/yanel/impl/resources/contactform/SendMail.java
> 
> is being used within the forget-password resource type and the SendMail 
> class seems to me very generic

Indeed.


> and hence it might make sense to move into
> some more common lib, e.g. the wyona-commons lib.
> 
> WDYT?

I thought about that when I wanted to reuse this piece of code, and 
decided against adding it to wyona-commons because it would basically 
transitively add a dependency to Javamail and JAF to all Wyona 
components that use wyona-commons, e.g. Yarep, Wyona-Security, Yanel, etc.

IMHO the "contact-form" resource-type is simple enough that it can be 
considered a mail library in itself: it would be a shame not to leverage 
resource-types to do dependency management each time we can to avoid a 
proliferation of plain-old-Java commons libraries. Of course the 
drawback that the code is then tied to Yanel (maybe only part of its API 
e.g. yanel-core if we are careful).


But maybe instead we could define a wyona-commons-mail "sub-library" as 
suggested for XML in 
http://svn.wyona.com/repos/public/commons/trunk/build.xml (look for 
"wyona-commons-xml")?
Then all commons sub-libraries could share a central building 
infrastructure but once compiled still live independently ever after! ;)


Cheers,
    Guillaume