[Yanel-dev] Bug cancel checkout fixed

[Guillaume Déflache]

Michael Wechner schrieb:
> Hi
> 
> I have fixed a bug re cancel checkout (especially when using Neutron 
> protocol).

Thanks, I didn't find a Yanel Bugzilla entry for this, there is probably 
none, or maybe one elsewhere: in Yulup?


> Because of this bug-fixing I have started to re-factor the Neutron java 
> implementation:
> 
> YANEL_HOME/src/neutron/
> 
> I think this code should be moved outside of Yanel in the long run, but 

See http://bugzilla.wyona.com/cgi-bin/bugzilla/show_bug.cgi?id=4963 and 
http://bugzilla.wyona.com/cgi-bin/bugzilla/show_bug.cgi?id=4964 (feel 
free to update them accordingly) whereas I am not sure if it makes sense 
to separate Neutron and Neutron-Auth...


> at least it's out of the YanelServlet now, which
> I would consider a good first step :-)

Sure trimming fat out of the YanelServlet is always good! :)


> There needs to be done some more re-factoring to get all Neutron related 
> code out and I will continue as much as time permits,
> but otherwise any help will be appreciated.

Thanks for your work, actually a few weeks ago while struggling to 
understand how the Neutron-Auth stuff works ( see the end of 
http://lists.wyona.org/pipermail/yanel-development/2009-May/003595.html 
) I had a go at moving it out of 
http://svn.wyona.com/repos/public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/security/impl/DefaultWebAuthenticatorImpl.java 
but failed short! :/
It would have been relatively easy to complete that without breaking 
anything except it uses the (reverse?) proxy configuration of the 
requested realm and that is of course strongly tied to Yanel.

At the time I found it was only defined on 
http://svn.wyona.com/repos/public/yanel/trunk/src/core/java/org/wyona/yanel/core/map/Realm.java 
but now I see there is also 
http://svn.wyona.com/repos/public/yanel/trunk/src/core/java/org/wyona/yanel/core/map/ReverseProxyConfig.java 
nearby! :)

So it looks like in DefaultWebAuthenticatorImpl we could use something 
like getReverseProxyConfig(request) from some new interface or abstract 
class in wyona-commons to abstract out the problematic stuff!

WDYT?