[Yanel-dev] Setting of YANEL_HOME

[Guillaume Déflache]

Guillaume Déflache schrieb:
> simon litwan schrieb:
>> Guillaume Déflache schrieb:
>>> Michael Wechner schrieb:
>>>> Alec Bickerton schrieb:
>>>>> Michael Wechner wrote:
>>>>>  
>>>>>> simon litwan schrieb:
>>>>>>  
>>>>>>> Michael Wechner schrieb:
>>>>>>>   
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> I have added the check for YANEL_HOME within build.sh, whereas it's
>>>>>>>> optional and one can continue the build by pressing enter/return 
>>>>>>>> key.
>>>>>>>>
>>>>>>>> I assume that Hudson will fail now, because YANEL_HOME is not set,
>>>>>>>> right? For this I see two possibilities, either
>>>>>>>> set YANEL_HOME also within Hudson and make this check somehow
>>>>>>>> configurable.
>>>>>>>>         
>>>>>>> i rather would solve this with an ant property.
>>>>>>>       
>>>>>> ok. Can you describe it a bit more detailed?
>>>>>>     
>>>>>
>>>>> If I understand correctly. Your suggesting we each create in our home
>>>>> directories a property file.
>>>>>   
>>>>
>>>> you mean for example
>>>>
>>>> /home/michi/.ant-global.properties
>>>>
>>>> and referencing it like
>>>>
>>>> <property file="${user.home}/.ant-global.properties"/>
>>>>
>>>> right?
>>>>
>>>> Sounds good to me. Will try to change it.
>>>>
>>>> Thanks
>>>>
>>>> Michael
>>>
>>> I think we do not need $HOME/.ant-global.properties anymore, at least 
>>> for setting ${yanel.home}, because
>>> for "build -f" we force it to the script directory anyway.
>>> So if you use the script from the Yanel source distribution you want 
>>> to use to run the resource-type Ant script, you no longer need to 
>>> indicate where the Yanel source is,e.g.:
>>> ---8<---
>>> cd /path/to/Yanel-working-copy # granted, we should not need to cd, 
>>> but that's another problem
>>> ./yanel.sh build -f src/resources/file/build.xml
>>> ---8<---
>>> ...simply works nowadays.
>>>
>>>>> In this file you would have all your local settings
>>>>> e.g.
>>>>>
>>>>> yanel.home=/home/alec/code/yanel_trunk
>>>>> tomcat.home=/opt/tomcat/
>>>
>>> Using another Tomcat is already possible from local.build.properties, 
>>> and I am not sure it makes sense for it to be a global (default) 
>>> setting anyway.
>>>
>>> Also AFAICS the way it is implemented ATM is that user-specific 
>>> properties override the Yanel source properties, which is backwards 
>>> IMHO: these should be fallback settings, not globally-enforced settings.
>> i'm glad if we don't need this global property anymore.
>>
>> simon
> 
> OK thanks, since nobody else seems to have a use for it, I am simply 
> going to remove it now.

Removed in revision 41906.
FYI this had never been available for Windows, only Unix.

As a side note, the ANT_OPTS environment variable seems to do precisely 
what we tried to achieve with $HOME/.ant-global.properties, cf. 
http://wiki.apache.org/ant/TheElementsOfAntStyle#head-aa823e51f49e2ccded5ffa84f7e28027b7ccb8c6 
("Use ANT_ARGS to set fixed command-line switches.").