[Yanel-dev] [Bug 6898] (too much) duplicate Ant code for resource types (including `yanel.sh build -f...` support)

[bugzilla at wyona.com]

http://bugzilla.wyona.com/cgi-bin/bugzilla/show_bug.cgi?id=6898


guillaume.deflache at wyona.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1112|                            |review?
               Flag|                            |




------- Comment #7 from guillaume.deflache at wyona.com  2009-03-04 10:59 -------
Created an attachment (id=1112)
 --> (http://bugzilla.wyona.com/cgi-bin/bugzilla/attachment.cgi?id=1112&action=view)
"inheritance" support for resource-types' Ant build files, tested on the "file"
RT

Implemented as suggested in comment 6.

Please svn cp src/resources/file/build.xml
src/build/resource-types/resource-type.build.xml before trying to apply the
patch, thanks!

Other notes:
---8<---
Stole code (from the "xinha" resource-type to take the package name from the
resource.xml file.

I also had to define the "yanel.source.home" Ant property each time a
resource-type build script gets called for Yanel build (I might have missed
other places where it happens, but so far everything seems to work).

Still need to figure out if the default target name can be inherited (maybe
with Ant 1.7?).


All this in the end means resource-types' build scripts depend on Yanel build
system, but IMHO this is OK as:
- we already depended on the properties anyway, so now we only depend on other
names, namely the build target names
- we can always version the common build script later if necessary
- binary and source compatibility should be enough, I am not sure we should
invest in build system compatibility
- this is a small price to pay to not drown under a sea of almost identical
build files :/


-- 
Configure bugmail: http://bugzilla.wyona.com/cgi-bin/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.