[Yanel-dev] Code review with Yanel

Michael Wechner michael.wechner at wyona.com
Mon Mar 2 15:48:17 CET 2009


Dear All

I would like to  introduce tomorrow a staging branch at

https://svn.wyona.com/repos/public/yanel/branches/staging

whereas we *all* commit into this branch instead into the trunk, which 
is the first rule.

(whereas it comes to my mind that we need to update 
http://yanel.wyona.org/en/development/processes/rtc.html ...)

The second rule is that with "each" commit we add a "review file".

The review file should be an XML and should describe which files belong 
together and which version (in case it wasn't committed atomically).

The third rule is that we need to somehow enforce the review such that 
the review stack never becomes too large
(for example every morning all reviews need to be examined before any 
further commits)

And so on  and on ...

I am sure there will be more trouble ahead (for example the rejection of 
a commit), but we need to get started somewhere.

Any objections?

Thanks

Michi

Michael Wechner schrieb:
> Michael Wechner schrieb:
>> Dear All
>>
>> I recently read a lot about  code review system as for example
>>
>> http://www.atlassian.com/software/crucible/default.jsp
>>
>> but there seem to be a lot of flaws with all the existing ones, so it 
>> came to my mind that with Yanel we could actually build one very 
>> nicely, whereas our first implementation could be SVN as the data 
>> repository (obviously ;-)
>>
>> So here is my suggestion:
>>
>> - We create code review realm with a code review resource, which 
>> allows to upload/check-in a file just as one would do with SVN
>> - We develop a repo implementation accessing three SVN branches:
>>     - trunk (all reviewed code)
>>     - staging branch (code which has not been reviewed yet, plus of 
>> course the reviewed files which are not changed)
>>    - workflow branch (for peformance reasons keep this separate)
>>
>>
>> This setup would have the following advantages:
>>    - One easily implement new backend repository implementation (for 
>> examle CVS)
>>    - One has the full information within the backend repository (for 
>> example SVN)
>>    - One has all the review logic nicely decoupled from the backend 
>> repository
>>
>> WDYT?
>
> btw, another possibilty would be that Yanel acts as SVN proxy, such 
> that one could use the SVN command line or Subclipse, but every change 
> would be treated as a file to be reviewed and then forewarded to the 
> actual SVN in the background (again the three branches)
>
> Cheers
>
> Michi
>>
>> Cheers
>>
>> Michi
>



More information about the Yanel-development mailing list