[Yanel-dev] Toolbar CSS

[Michael Wechner]

Guillaume Déflache schrieb:
> Michael Wechner schrieb:
>> I made some minor improvements re the toolbar CSS
>>
>> src/webapp/htdocs/toolbar.css
>>
>> but I think we should refactor it quite a bit, for example
>
> Sure, see also my reply on one commit.
> Also it seems like there are still some CSS rules in the HTML header.

yes, because some paths are dynamic. I think the only way how we can fix 
this is by generating the CSS dynamically.

Or is there any other approach?
> And the browser detection code in 
> http://svn.wyona.com/repos/public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/YanelHTMLUI.java 
> for CSS generation looks whoefully outdated, e.g. it seems to take 
> care of IE < 6, which probably is not worth the effort nowadays!

I haven't checked the statistics ...
>
>
>> yaneltoolbar_menutitle is actually occuring several times, but 
>> nevertheless is set with id instead class
>>
>> but the problem with this example is backwards compatibility and that 
>> the toolbars use hardcoded styles.
>
> Well did it worked anyway with these multiple ids?

yes, but I think it's not best practice at all
>
> And WDYM by "hardcoded styles"?

third party projects can have their own toolbar implementations, but 
these are also using the CSS which we provided, because
it's basically an API (but not declared as such) and hence we cannot 
just change things
>
>
>> Any suggestions how to improve this are very welcome
>
>
> Maybe create another set of CSS: toolbar2*.css (and please do use svn 
> cp to do it if you do!)

yes, we should introduce a new version of CSS, but also provide a 
framework for generating the toolbar and also
declare API.

Cheers

Michi