[Yanel-dev] don't show svn files when browsing a repo sitetree (at least for yanel-website)

[simon litwan]

Michael Wechner schrieb:
> simon litwan schrieb:
>> Michael Wechner schrieb:
>>> simon litwan schrieb:
>>>> hi all
>>>>
>>>> i would like to propose following patch:
>>>>
>>>> Index: src/realms/yanel-website/config/res-config-repository.xml
>>>> ===================================================================
>>>> --- src/realms/yanel-website/config/res-config-repository.xml    
>>>> (revision 41380)
>>>> +++ src/realms/yanel-website/config/res-config-repository.xml    
>>>> (working copy)
>>>> @@ -2,7 +2,9 @@
>>>>
>>>> <repository 
>>>> class="org.wyona.yarep.impl.repo.vfs.VirtualFileSystemRepository">
>>>>   <name>Yanel Website Resource Configurations Repository</name>
>>>> -  <content src="../res-configs-repo/data"/>
>>>> +  <content src="../res-configs-repo/data">
>>>> +    <ignore pattern=".*\.svn"/>
>>>> +  </content>
>>>>   <meta src="../res-configs-repo/yarep-meta"/>
>>>>   <search-index src="../res-configs-repo/search-index"/>
>>>> </repository>
>>>>
>>>> WDOT?
>>>
>>> +1
>> i commited (r41408) the change for res-config-repository.xml but not 
>> for repository.xml.
>> since this is only implemented within the VirtualFileSystemRepository 
>> but not in FileSystemRepository.
>>
>> in FileSystemRepository one can configure ignore patterns within the 
>> map configuration. i guess as long as you disable fallback this is fine.
>> but otherwise there will be no way to hide svn files when fallback is 
>> enabled.
>> shouldn't we implement the content ignore pattern for 
>> FileSystemRepository as well?
>
> yes, I think this would make sense
ok
>>
>> BTW i would prefer to use one repo implementation (e.g. 
>> VirtualFileSystemRepository) as kind of standard. i think it would 
>> make yanel simpler to learn and understand if simple examples use 
>> simple implementations.
>
> agreed
>> since it's easy to create new realms, i would prefer use example 
>> realms to demonstrate other (more specialized) implementations of 
>> components.
>
> I am not sure I understand. Can you explain a bit ...
will try later ...
>>
>> or is there any reason to use FileSystemRepository for the 
>> res-config-realm?
>
> in which particular case?
in the yanel-website realm. the data-repo uses 
VirtualFileSystemRepository and the res-config-repo uses 
FileSystemRepository.

simon
>
> Thanks
>
> Michi
>>
>> simon
>>>
>>>
>>> Michi
>>>>
>>>> simon
>>>
>>
>