[Yanel-dev] cleanup comments
Guillaume Déflache
guillaume.deflache at wyona.com
Wed Dec 10 10:29:20 CET 2008
Alec Bickerton schrieb:
>> I wonder what is the rationale for this: why not use an import for
>> static accesses as well?
>> I reckon it make use of static methods or classes look even uglier,
>> which is probably a good idea OOP-wise, but is there a more practical
>> reason?
>
> I see no problem with doing this. I'm not entirely sure what the static
> analysis tools will show up in this case though.
You mean static analysis tools may _require_ fully-qualified symbols for
all static accesses to be able to do their job? Seems odd.
>> Also an unrelated question: I always use curly braces for if and else
>> branches, except for guards like:
>> if (log.isDebugEnabled()) log.debug("foo: ", foo);
>> ...and I am tempted to do that for early returns as well, always keeping
>> everything on the same line to avoid mistakes.
>> Can we tolerate these exceptions without bothering anyone and some
>> static code checker?
>
> Yes, code as shown abovw would be unlikely to generate warnings using
> our current tool chain.
That's the _future_ toolchain I was worried about! ;)
More information about the Yanel-development
mailing list