[Yanel-dev] cleanup comments

Alec Bickerton alec.bickerton at wyona.com
Wed Dec 10 09:48:22 CET 2008


Guillaume Déflache wrote:
> Hi!
> 
> First many thanks to Alec for the patch and to Michi for applying it, it
> must have tedious for both!
> 
> A few comments on the big cleanup:

snip...

> I wonder what is the rationale for this: why not use an import for
> static accesses as well?
> I reckon it make use of static methods or classes look even uglier,
> which is probably a good idea OOP-wise, but is there a more practical
> reason?

I see no problem with doing this. I'm not entirely sure what the static
analysis tools will show up in this case though.

> Also an unrelated question: I always use curly braces for if and else
> branches, except for guards like:
> if (log.isDebugEnabled()) log.debug("foo: ", foo);
> ...and I am tempted to do that for early returns as well, always keeping
> everything on the same line to avoid mistakes.
> Can we tolerate these exceptions without bothering anyone and some
> static code checker?

Yes, code as shown abovw would be unlikely to generate warnings using
our current tool chain.

> I don't mind too much either way really, I just don't want to throw
> spurious warnings onto anyone's screen! ;)

That's good too.

Alec,


More information about the Yanel-development mailing list