[Yanel-dev] cleanup comments

Gary Jones gary.jones at wyona.com
Wed Dec 10 09:44:29 CET 2008


Guillaume Déflache <guillaume.deflache at wyona.com> writes:

> Also an unrelated question: I always use curly braces for if and else
> branches,

If only everyone was so well behaved ;-)

> except for guards like:
> if (log.isDebugEnabled()) log.debug("foo: ", foo);
> ...and I am tempted to do that for early returns as well, always keeping
> everything on the same line to avoid mistakes.
> Can we tolerate these exceptions without bothering anyone and some
> static code checker?

You can suppress PMD warnings as described at
http://pmd.sourceforge.net/suppressing.html but of course other tools
have different ways of doing it, if they have any way at all. I'm not
sure what Alec used to decide on his patch contents, probably PMD, but
I'm not sure.

@Alec: if you did run PMD, did you also try the copy/paste detector?

-- 
Gary


More information about the Yanel-development mailing list