[Yanel-dev] more tests for YanelServlet

[Guillaume Déflache]

Hi all!

Guillaume D=E9flache schrieb:
> Next I plan to cleanup URL matching there a bit as the code is really =

> difficult to follow, but I needed tests first!

This is done for global data in the attached patch, hoping the code is =

now clearer also for others!
The URL matching is quite a bit stricter than before, but IMHO all =

normal and intended use cases are covered, as the tests in the previous =

patch all pass! :)

As a "bonus", I also made a few (private) methods static to ease moving =

them elsewhere later, as the servlet is already pretty crowded and =

inherently difficult to test.
Also the method "getGlobalData" was made private for the same reasons, =

it seems pretty safe to assume it is not used by the outside world =

unless someone somewhere instantiates the Yanel servlet manually!?!

Cheers,
    Guillaume
-------------- next part --------------
A non-text attachment was scrubbed...
Name: YanelServlet_refactored-global-data-URI-matching.patch
Type: text/x-diff
Size: 7169 bytes
Desc: not available
Url : http://wyona.com/pipermail/yanel-development/attachments/20081204/e32=
6cb7b/YanelServlet_refactored-global-data-URI-matching-0001.bin