[Yanel-dev] ViewableV2.getMimeType()

[Josias Thöny]

Michael Wechner wrote:
> Hi
> 
> I gave ViewableV2.getMimeType() some more thought and suddenly thought 
> that this is needed if the resource writes into the response directly 
> and sets
> 
> View.setResponse(false)
> 
> resp. which is being checked by the YanelServlet for instance
> 
> view.isResponse()

I guess if a resouce writes directly into the response, then the 
resource is also reponsible to set the http header with the correct mime 
type, and the servlet shouldn't call either one of the getMimeType() 
methods.

> 
> but I didn't find any place where this method is actually being used.
> 
> I have commented it locally
> 
>     /**
>      * Mime type of resource, e.g. application/xhtml+xml, whereas it can 
> depend on view id
>      */
> -    public String getMimeType(String viewId) throws Exception;
> +    //public String getMimeType(String viewId) throws Exception;
> }
> 
> and Yanel and all resources build fine.
> 
> Since ViewableV2 is not released yet, shall we delete it?
> 
> WDYT?

+1 to remove ViewableV2.getMimeType(String viewId)

josias


> 
> Cheers
> 
> Michi
>