[Yanel-dev] RealmConfiguration is kind of misleading as a name

Josias Thöny josias.thoeny at wyona.com
Wed May 16 09:19:30 CEST 2007


On Tue, 2007-05-15 at 23:35 +0200, Michael Wechner wrote:
> Josias Thöny wrote:
> 
> >On Mon, 2007-05-14 at 09:50 +0200, Michael Wechner wrote:
> >  
> >
> >>Josias Thöny wrote:
> >>
> >>    
> >>
> >>>On Sat, 2007-05-12 at 13:35 +0200, Michael Wechner wrote:
> >>> 
> >>>
> >>>      
> >>>
> >>>>Hi
> >>>>
> >>>>I think the class name RealmConfiguration is a bit misleading, because 
> >>>>one want think that it is re the configuration of one realm and not of 
> >>>>all the realms being registered within Yanel. Hence I think it would 
> >>>>make sense to rename it.
> >>>>
> >>>>WDYT?
> >>>>   
> >>>>
> >>>>        
> >>>>
> >>>+1 for renaming.
> >>>This class is not only about configuration, it's also provides methods
> >>>to e.g. add a new realm, so maybe we could rename it to "RealmManager".
> >>>Any better ideas?
> >>> 
> >>>
> >>>      
> >>>
> >>RealmManager sounds good to me
> >>
> >>    
> >>
> >>>And maybe we could also move this class and Realm.java from
> >>>org.wyona.yanel.core.map to org.wyona.yanel.core,
> >>>
> >>>      
> >>>
> >>makes sense, because I would say it's on the same "purpose level" as a 
> >>resource
> >>
> >>    
> >>
> >>>or is there a reason
> >>>why these two classes belong to the map package?
> >>> 
> >>>
> >>>      
> >>>
> >>I guess because a realm is part of the map layout, but do not really 
> >>remember ;-)
> >>
> >>The question is if we move this two classes, will it then break the 
> >>implemented resources
> >>I guess it should't because resource are accessing the realm through 
> >>getRealm(), right?
> >>    
> >>
> >
> >Hm, some resources are importing org.wyona.yanel.core.map.Realm, so they
> >would break.
> >The other resources which just use getRealm() without using the package
> >name might still need to be recompiled.
> >Should we keep the current package structure to avoid problems?
> >  
> >
> 
> yes, whereas we could set it to deprecated and copy it to the core dir
> and refactor the resources which are being part of Yanel distribution.
> 
> WDYT?

ok, this should work.

josias

> 
> Cheers
> 
> Michi
> 
> >Josias
> >
> >  
> >
> >>Cheers
> >>
> >>Michi
> >>
> >>    
> >>
> >>>Josias
> >>>
> >>> 
> >>>
> >>>      
> >>>
> >>>>Cheers
> >>>>
> >>>>Michi
> >>>>
> >>>>   
> >>>>
> >>>>        
> >>>>
> >>>_______________________________________________
> >>>Yanel-development mailing list
> >>>Yanel-development at wyona.com
> >>>http://wyona.com/cgi-bin/mailman/listinfo/yanel-development
> >>>
> >>> 
> >>>
> >>>      
> >>>
> >>    
> >>
> >
> >
> >_______________________________________________
> >Yanel-development mailing list
> >Yanel-development at wyona.com
> >http://wyona.com/cgi-bin/mailman/listinfo/yanel-development
> >
> >  
> >
> 
> 




More information about the Yanel-development mailing list