[Yanel-commits] rev 47587 - public/yanel/trunk/src/contributions/resources/policymanager/src/java/org/wyona/yanel/impl/resources/policymanager

michi at wyona.com michi at wyona.com
Sat Feb 13 08:13:32 CET 2010


Author: michi
Date: 2010-02-13 08:13:32 +0100 (Sat, 13 Feb 2010)
New Revision: 47587

Modified:
   public/yanel/trunk/src/contributions/resources/policymanager/src/java/org/wyona/yanel/impl/resources/policymanager/PolicyManagerResource.java
Log:
javadoc added, some more docu re peformance issues added and code simplified

Modified: public/yanel/trunk/src/contributions/resources/policymanager/src/java/org/wyona/yanel/impl/resources/policymanager/PolicyManagerResource.java
===================================================================
--- public/yanel/trunk/src/contributions/resources/policymanager/src/java/org/wyona/yanel/impl/resources/policymanager/PolicyManagerResource.java	2010-02-13 06:58:12 UTC (rev 47586)
+++ public/yanel/trunk/src/contributions/resources/policymanager/src/java/org/wyona/yanel/impl/resources/policymanager/PolicyManagerResource.java	2010-02-13 07:13:32 UTC (rev 47587)
@@ -218,7 +218,7 @@
     }; 
 
     /**
-     *
+     * Get users, groups and rights as XML
      */
     private String getIdentitiesAndRightsAsXML(IdentityManager im, PolicyManager pm, String language) {
         UserManager um = im.getUserManager();
@@ -228,14 +228,14 @@
         sb.append("<access-control xmlns=\"http://www.wyona.org/security/1.0\">");
 
         try {
-            boolean refreshUsers = true; // correctness trumps speed!
+            boolean refreshUsers = true; // INFO: By default refresh all users, but please be aware that this can lead to severe performance issues, for example if used within a slow LDAP environment. Hence we make it configurable below.
             String refreshUsersText = getResourceConfigProperty(REFRESH_USERS_RC_PROPERTY_NAME);
             if (refreshUsersText != null && "false".equals(refreshUsersText)) {
                 refreshUsers = false;
                 log.warn("Users will not be loaded afresh!");
             }
 
-            User[] users = refreshUsers ? um.getUsers(true) : um.getUsers();
+            User[] users = um.getUsers(refreshUsers);
             Arrays.sort(users, new ItemIDComparator());
             appendSecurityItemsAsXML(users, getUserExtraPropertiesGetter(), "user", sb);
 



More information about the Yanel-commits mailing list