[Yanel-commits] rev 49012 - public/yanel/trunk/src/webapp/htdocs/Google-Analytics

[michi at wyona.com]

Author: michi
Date: 2010-04-23 14:00:41 +0200 (Fri, 23 Apr 2010)
New Revision: 49012

Modified:
   public/yanel/trunk/src/webapp/htdocs/Google-Analytics/GA.xslt
Log:
comments improved and workaround re also checking .htm etc.

Modified: public/yanel/trunk/src/webapp/htdocs/Google-Analytics/GA.xslt
===================================================================
--- public/yanel/trunk/src/webapp/htdocs/Google-Analytics/GA.xslt	2010-04-23 11:56:35 UTC (rev 49011)
+++ public/yanel/trunk/src/webapp/htdocs/Google-Analytics/GA.xslt	2010-04-23 12:00:41 UTC (rev 49012)
@@ -37,12 +37,21 @@
       <xsl:text>no</xsl:text>
     </xsl:when>
 
-    <!-- NOTE: At the moment the suffix is only compared with .html (see $non-asset-URL-suffix) -->
+    <!-- NOTE: Check if an URL does NOT end with .html and hence assume it is an asset. At the moment the suffix is only compared with .html (see $non-asset-URL-suffix) -->
     <!-- At the moment the following cases are not checked: .htm, foo-bar/, foo-bar -->
-    <!--FIXME HACK: find a better method to differentiate document assets from pages: -->
+    <!--FIXME HACK: find a better method to differentiate document assets (e.g. pdf, doc) from pages: -->
     <xsl:when test="substring($url_without_qs, 1 + string-length($url_without_qs) - string-length($non-asset-URL-suffix)) != $non-asset-URL-suffix"><!-- Equals to expression: not(ends-with($url_without_qs, $non-asset-URL-suffix)) -->
       <xsl:text>yes</xsl:text>
     </xsl:when>
+    <!-- NOTE: As a workaround we just hardcode all other suffixes which shall be excluded! -->
+<!--
+    <xsl:when test="substring($url_without_qs, 1 + string-length($url_without_qs) - string-length('.htm')) != '.htm'">
+      <xsl:text>yes</xsl:text>
+    </xsl:when>
+    <xsl:when test="substring($url_without_qs, 1 + string-length($url_without_qs) - string-length('#')) != '#'">
+      <xsl:text>yes</xsl:text>
+    </xsl:when>
+-->
 
     <xsl:otherwise>
       <xsl:text>no</xsl:text>