[Yanel-commits] rev 45233 - public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client

michi at wyona.com michi at wyona.com
Wed Oct 28 14:11:53 CET 2009


Author: michi
Date: 2009-10-28 14:11:53 +0100 (Wed, 28 Oct 2009)
New Revision: 45233

Modified:
   public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/AccessPolicyEditor.java
   public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/IdentitiesListBoxWidget.java
Log:
visible item count fixed for identities

Modified: public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/AccessPolicyEditor.java
===================================================================
--- public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/AccessPolicyEditor.java	2009-10-28 11:51:53 UTC (rev 45232)
+++ public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/AccessPolicyEditor.java	2009-10-28 13:11:53 UTC (rev 45233)
@@ -87,14 +87,11 @@
         }
 
         // Get identities/groups and available rights from server
-        getIdentitiesAndRights(identitiesURL);
-
         identitiesLBW = new IdentitiesListBoxWidget(visibleItemCount, language);
-        identitiesLBW.set(visibleItemCount, identitiesAllUsers, identitiesAllGroups);
+        getIdentitiesAndRights(identitiesURL);
         
-        policyLBW = new PolicyListBoxWidget(visibleItemCount, policyUsers, policyGroups, useInheritedPolicies, language);
-
         // Get policy from server (within getPolicy() the identities list will be updated accordingly)
+        policyLBW = new PolicyListBoxWidget(visibleItemCount, policyUsers, policyGroups, useInheritedPolicies, language);
         getPolicy(readPolicyURL);
 
         // Setup GUI
@@ -239,7 +236,7 @@
                     public void run() {
                         if (request.isPending()) {
                             rightsIdentitiesRetrievalCompleted = false;
-                            identitiesLBW.displayLoadingIdentities();
+                            identitiesLBW.displayLoadingIdentities(visibleItemCount);
                             scheduleRepeating(10);
                         } else {
                             rightsIdentitiesRetrievalCompleted = true;
@@ -326,7 +323,6 @@
                         tmpGroups.toArray(tmpGroupStr);
                         identitiesAllGroups = tmpGroupStr;
                         
-                        identitiesLBW.set(visibleItemCount, new String[0], new String[0]);
                         identitiesLBW.set(visibleItemCount, identitiesAllUsers, identitiesAllGroups);
                         //Window.alert("Policy has been loaded!");
                     }

Modified: public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/IdentitiesListBoxWidget.java
===================================================================
--- public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/IdentitiesListBoxWidget.java	2009-10-28 11:51:53 UTC (rev 45232)
+++ public/yanel/contributions/ajax-components/src/access-policy-editor/java/org/wyona/security/gwt/accesspolicyeditor/client/IdentitiesListBoxWidget.java	2009-10-28 13:11:53 UTC (rev 45233)
@@ -59,18 +59,19 @@
     /**
      *
      */
-    public void displayLoadingIdentities() {
+    public void displayLoadingIdentities(int visibleItemCount) {
         lb.clear();
+        lb.setVisibleItemCount(visibleItemCount);
         lb.addItem("Loading users/groups ...");
         lb.addItem("Thanks for being patient!");
     }
 
     /**
-     *
+     * Set users and groups as list items
      */
     public void set(int visibleItemCount, String[] users, String[] groups) {
         if (users == null && groups == null) {
-            displayLoadingIdentities();
+            displayLoadingIdentities(visibleItemCount);
             return;
         }
 



More information about the Yanel-commits mailing list