[Yanel-commits] rev 44498 - public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow

[michi at wyona.com]

Author: michi
Date: 2009-08-31 13:43:29 +0200 (Mon, 31 Aug 2009)
New Revision: 44498

Modified:
   public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowHelper.java
Log:
log added, because this is an implementation specific check and should actually be handled via the interface

Modified: public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowHelper.java
===================================================================
--- public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowHelper.java	2009-08-31 11:36:52 UTC (rev 44497)
+++ public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowHelper.java	2009-08-31 11:43:29 UTC (rev 44498)
@@ -47,6 +47,7 @@
     protected static final String LIVE_REVISION_PROPERTY = "live-revision";
     protected static final String WORKFLOW_DATE_PROPERTY = "workflow-date";
     protected static final String WORKFLOW_STATE_PROPERTY = "workflow-state";
+    protected static final String WORKFLOW_SCHEMA_PROPERTY_NAME = "workflow-schema";
 
     public static void doTransition(Resource resource, String transitionID, String revision) 
             throws WorkflowException {
@@ -166,8 +167,10 @@
      */
     public static boolean hasWorkflow(Resource resource) throws WorkflowException {
         try {
-            if (resource.getResourceConfigProperty("workflow-schema") != null) {
+            if (resource.getResourceConfigProperty(WORKFLOW_SCHEMA_PROPERTY_NAME) != null) {
                 return true;
+            } else {
+                log.warn("Resource configuration does not contain a '" + WORKFLOW_SCHEMA_PROPERTY_NAME + "' property!");
             }
         } catch (Exception e) {
             log.warn(e.getMessage());
@@ -180,7 +183,7 @@
      */
     public static Workflow getWorkflow(Resource resource) throws WorkflowException {
         try {
-            String workflowSchema = resource.getResourceConfigProperty("workflow-schema");
+            String workflowSchema = resource.getResourceConfigProperty(WORKFLOW_SCHEMA_PROPERTY_NAME);
             if (workflowSchema == null) {
                 return null;
             }