[Yanel-commits] rev 26330 - public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet

michi at wyona.com michi at wyona.com
Thu Jul 26 23:17:27 CEST 2007


Author: michi
Date: 2007-07-26 23:17:27 +0200 (Thu, 26 Jul 2007)
New Revision: 26330

Modified:
   public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/YanelServlet.java
Log:
return an error when resource is not viewable

Modified: public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/YanelServlet.java
===================================================================
--- public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/YanelServlet.java	2007-07-26 20:41:16 UTC (rev 26329)
+++ public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/YanelServlet.java	2007-07-26 21:17:27 UTC (rev 26330)
@@ -456,7 +456,6 @@
                             // TODO: Log all 404 within a dedicated file (with client info attached) such that an admin can react to it ...
                             String message = "No such node exception: " + e;
                             log.warn(e);
-                            //log.error(e.getMessage(), e);
                             Element exceptionElement = (Element) rootElement.appendChild(doc.createElementNS(NAMESPACE, "exception"));
                             exceptionElement.appendChild(doc.createTextNode(message));
                             exceptionElement.setAttributeNS(NAMESPACE, "status", "404");
@@ -466,7 +465,15 @@
                         }
                     } else {
                          Element noViewElement = (Element) resourceElement.appendChild(doc.createElement("not-viewable"));
+                         String message = res.getClass().getName() + " is not viewable! (" + res.getPath() + ", " + res.getRealm() + ")";
                          noViewElement.appendChild(doc.createTextNode(res.getClass().getName() + " is not viewable!"));
+                         log.error(message);
+                         Element exceptionElement = (Element) rootElement.appendChild(doc.createElementNS(NAMESPACE, "exception"));
+                         exceptionElement.appendChild(doc.createTextNode(message));
+                         exceptionElement.setAttributeNS(NAMESPACE, "status", "501");
+                         response.setStatus(javax.servlet.http.HttpServletResponse.SC_NOT_IMPLEMENTED);
+                         setYanelOutput(request, response, doc);
+                         return;
                     }
                     if (ResourceAttributeHelper.hasAttributeImplemented(res, "Modifiable", "2")) {
                         lastModified = ((ModifiableV2) res).getLastModified();



More information about the Yanel-commits mailing list