[Osr-101] Re: [Yulup-commits] rev 23793 - in public/yulup/src/branches: . WIDGET_REFACTORING_BRANCH/yulup/src/templates/src/html.nar

[Thomas Comiotto]

Hi Andi,


Wouldn't it make sense to discuss how to approach widget bindings on  
osr-101 beforehand?

Anyway some short notes re your approach:

  - does not separate GUI frontend from the datatype related stuff.  
Editor vendors should be free to and will use their own icons, labels  
(i18n!) and so on.
  - tries to model commands instead of providing data for configuring  
commands.
  - it's quite verbose. Can you make a complete example for a table  
widget?
  - it's flexible by not implying basic methods of a particular  
widget. Nice and well, but do we really need that? I'd rather define  
a fixed set of widgets and take the corresponding functionality for  
granted: it's evident that a bold command is ment to surrounds a  
selected range, a table can basically contains rows and cells and so  
on. If widgets are about document formatting then keep it as simple  
as possible.
  - mapping fragments to widget components/commands is misleading.  
It's about mapping *datatype declarations* to widget components/commands

Cheers
Thomas




On Apr 16, 2007, at 6:50 PM, andi at wyona.com wrote:

> Author: andi
> Date: 2007-04-16 18:50:47 +0200 (Mon, 16 Apr 2007)
> New Revision: 23793
>
> Added:
>    public/yulup/src/branches/WIDGET_REFACTORING_BRANCH/
> Modified:
>    public/yulup/src/branches/WIDGET_REFACTORING_BRANCH/yulup/src/ 
> templates/src/html.nar/introspection.xml
> Log:
> Added new branch for widget refactoring.
>
>
> Copied: public/yulup/src/branches/WIDGET_REFACTORING_BRANCH (from  
> rev 23792, public/yulup/src/trunk)
>
> Modified: public/yulup/src/branches/WIDGET_REFACTORING_BRANCH/yulup/ 
> src/templates/src/html.nar/introspection.xml
> ===================================================================
> --- public/yulup/src/trunk/yulup/src/templates/src/html.nar/ 
> introspection.xml	2007-04-16 13:48:38 UTC (rev 23792)
> +++ public/yulup/src/branches/WIDGET_REFACTORING_BRANCH/yulup/src/ 
> templates/src/html.nar/introspection.xml	2007-04-16 16:50:47 UTC  
> (rev 23793)
> @@ -76,6 +76,23 @@
>          </fragment>
>        </widget>
>      </widgets>
> +    <widget name="Asset" description="Insert Asset" icon="icons/ 
> asset.png">
> +      <surround>
> +        <attribute name="href" xpath="a/attribute::href"  
> type="resource"/>
> +        <fragment>
> +          <a xmlns="" href=""/>
> +        </fragment>
> +      </surround>
> +      <insert>
> +        <attribute name="href" xpath="a/attribute::href"  
> type="resource"/>
> +        <attribute name="alt" xpath="a/img/attribute::alt"/>
> +        <fragment>
> +          <a xmlns="" href="">
> +            <object class="asset"/>
> +          </a>
> +        </fragment>
> +      </insert>
> +    </widget>
>    </edit>
>
>    <new>
>
>
> _______________________________________________
> Phoenix-commits mailing list
> Phoenix-commits at wyona.com
> http://wyona.com/cgi-bin/mailman/listinfo/phoenix-commits
>